Bug 1201110 - Schema changes to support bookmark sync. #1224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rnewman
force-pushed
the
rnewman/bm
branch
5 times, most recently
from
5354cc8
to
6ffb72e
Compare
rnewman
force-pushed
the
rnewman/bm
branch
6 times, most recently
from
77ce349
to
987855e
Compare
rnewman
force-pushed
the
rnewman/bm
branch
14 times, most recently
from
92acfac
to
e5c95e7
Compare
…ion and overriding correctly.
…y on SQLiteBookmarks.
…ingBookmarksSynchronizer.
|
@ncalexan: everything new, up to "Bug 1233193, Bug 1201110 - Majorly rework bookmark tests.", is ready for a second look — primarily this makes the tests a lot nicer and more thorough, and correctly implements recursive deletion of folders and all records matching a URL. The tests create a non-trivial mirrored bookmark tree, make some local changes, and then delete a subtree and by URL. Ignore the merger work at the end. |
|
All review comments addressed, so I'll rebase and truncate off the merger stuff and continue in #1385. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a wild romp through our database schema. WIP.