Better handle invalid schemes #1300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
st3fan
force-pushed
the
st3fan/Bug1224910BetterHandleInvalidSchemes
branch
from
cef7094
to
a2fa603
Compare
| @@ -1678,13 +1683,30 @@ extension BrowserViewController: WKNavigationDelegate { | |||
| } | |||
| } | |||
|
|
|||
| /// List of schemes that are allowed to open a popup window | |||
thebnich
changed the title
thebnich
changed the title
st3fan
force-pushed
the
st3fan/Bug1224910BetterHandleInvalidSchemes
branch
from
d12dd38
to
2244e4c
Compare
st3fan
added a commit
that referenced
this pull request
Nov 30, 2015
…validSchemes Better handle invalid schemes
isabelrios
pushed a commit
to isabelrios/firefox-ios
that referenced
this pull request
Feb 19, 2024
…e#1305) * Added new test * Update project.pbxproj * Update project.pbxproj
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two related fixes in this patch:
• Better handle invalid schemes opened in popup windows. If the scheme is not in our whitelist, we consider it invalid and open a new tab without a context (WKConfiguration) that links to the parent window. After that
webView:decidePolicyForNavigationAction:will be called and will show an appropriate error message that the URL cannot be opened.• Make use of the new
WKFrameInfo.securityOriginto show better detailed titles in JavaScript originated alerts. (Via theWKWebViewdelegate)The second is as a result of the first. With the first now allowing
javascript:URLs resulted in a crash that is fixed by the second fix.