Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1270693 - FindInPageBar Keyboard Improvements #1782

Merged
merged 3 commits into from May 11, 2016

Conversation

st3fan
Copy link
Contributor

@st3fan st3fan commented May 6, 2016

This patch does three things:

  • Remove the shortcuts bar for less clutter and safari parity. See screenshots below. This only affects iPad and iOS9.
  • Enable enablesReturnKeyAutomatically so that the return key stays disabled unless there is content in the field
  • Change the return key to be Search instead

Virtual Keyboard Before/After

screenshot 2016-05-06 08 22 44
screenshot 2016-05-06 08 29 47

Hardware Keyboard Before/After

screenshot 2016-05-06 08 22 50
screenshot 2016-05-06 08 29 52

@st3fan st3fan merged commit 55d85eb into master May 11, 2016
@farhanpatel farhanpatel deleted the st3fan/FindInPageKeyboardImprovements branch October 6, 2016 06:59
isabelrios pushed a commit to isabelrios/firefox-ios that referenced this pull request Feb 19, 2024
isabelrios pushed a commit to isabelrios/firefox-ios that referenced this pull request Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant