Bug 1289717 - Fixed floating HomePanelViewController if tabs are opened too quickly #2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tylerlacroix
changed the title
|
From my investigation, it looks like when the new tabs are opened quickly, a new tab can be created before the animation is completed. This can cause a "floating" HomePanelViewController [1], because it sets self.homePanelController to nil after the animation, but the self.homePanelController may no longer be the correct homePanel. [1] |
sleroux
pushed a commit
that referenced
this pull request
Aug 8, 2016
…ed too quickly (#2020) r=sleroux
isabelrios
pushed a commit
to isabelrios/firefox-ios
that referenced
this pull request
Feb 19, 2024
…olors/style (mozilla-mobile#2020) Co-authored-by: Bogdan Cernea <bogdan.cernea@softvision.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.