Bug 1139053 - login state machine #251
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cit error types. Previously, we made NSError implement ErrorType. This is convenient but unwieldy when errors at a low level of the stack are expected and need to be interrogated and acted upon. In this situation, explicit errors (with NSError sub-cases or fallbacks) are better.
…ze code. This is adds some intermediate states that I intend to use to provide less abrasive user notifications during the verification loop, and to make the login state machine simpler. This is a renaming, completion, and modernization commit.
|
This looks good to me. Let's find out if it works! |
|
This landed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.