Bug 1165481 - Reader #469
Closed
Bug 1165481 - Reader #469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| github "rs/SDWebImage" "3.7.2" | ||
| github "st3fan/SQLite.swift" "91839c620f3912eec83cb098c02213438cee480c" | ||
| github "CEWendel/SWTableViewCell" "0.3.7" | ||
| github "st3fan/SWXMLHash" "052bd278e88d024d83dcbd570bfce3b35de87573" | ||
| github "Masonry/Snap" "0.11.0" | ||
| github "DaveWoodCom/XCGLogger" "29b77cc64147aa09fe233ad2c90007fb4cd1fbf5" | ||
| github "DaveWoodCom/XCGLogger" "74390d672ed2256360ea48f289286718afc9efe6" | ||
| github "mozilla/readability" "85101066386a0872526a6c4ae164c18fcd6cc1db" |
There was a problem hiding this comment.
This patch also upgrades other dependencies. I think that is fine in this case because they are all minor version increments, but we should be careful with that.
|
This does not work for me. I did a clean checkout and ran Do you want me to fix this? |
|
I'm picking this up. Going to close this PR and create a new one. |
isabelrios
pushed a commit
to isabelrios/firefox-ios
that referenced
this pull request
Feb 19, 2024
* Custom Domains: Settings * Custom Domains: UI cleanup * Custom Domains: Color updates * Custom Domains: Add tests * Custom Domain: Add url bar tests * add telemetry * Adds a custom cell for the search section * Adds the autocomplete cell * Toggle enabled/disabled on the Autocomplete cell * Refactors AutoCompleteSettingsViewController to match new UX * adds setting for custom autocomplete * fixes string constants * start migrating logic from AutocompleteSettingVC to AutocompleteCustomUrl * fixes tableview styling * fixes the tableview header on th list page * setup edit UI for the custom URL list * wraps up autocomplete UI * empty state for domain list * refactor doneTapped to only have one guard * pulls out textfield into its own class * refactor domain completion management, re-adds ability to add domains to custom list * re-add telemetry * Adds ability to remove custom domains * adds logic to enable the autocomplete lists * Pulls out PaddedSwitch * switch to a result type * Changes AddCustomDomainViewController to use the customSource protocol * fixes bug where empty view message appears while not in editing mode * Adds re-ordering of cells * fixes error message logic * Fixes some minor nits * unify tableview headers on the URLAutocomplete settings * removes unused constants * fixes errors from rebase * Fixes UITests for autocomplete * fixes UITest for using a custom autocomplete * re-adds about button * disable edit button when there are no elements to display
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has changed a lot since we originally imported it. This updates us to their current tip (and makes further updates just some Cartfile changes). I don't see any big differences in the articles.