Fixes 1179846 - Update Bookmark and Reading List status after UIActivityViewController runs #731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Result of integration 1 |
…ityViewController runs
st3fan
force-pushed
the
st3fan/Bug1179846UpdatePageStatusAfterShare
branch
from
013c119
to
60ff97f
Compare
st3fan
added a commit
that referenced
this pull request
Jul 15, 2015
…sAfterShare Fixes 1179846 - Update Bookmark and Reading List status after UIActivityViewController runs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch catches the case where we do not update the status when the user adds the current page to either Bookmarks or Reading List. We don't really know if the user did, so we always update the state when the
UIActivityViewControlleris dismissed withcompletedstatus.This patch also cleans up
updateNavigationToolbarStates()a bit, which previously took both aBrowserand aWKWebView. I don't think that made sense because thewebViewwas alwaysbrowser.webView.