Fixes 1191767 - Do not manually handle keyboard overlapping with WKWebView #877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -90,15 +90,22 @@ class SettingsContentViewController: UIViewController, WKNavigationDelegate { | |||
|
|
|||
| self.webView = makeWebView() | |||
| view.addSubview(webView) | |||
| self.webView.snp_remakeConstraints { make in | |||
| make.left.right.top.equalTo(self.view) | |||
There was a problem hiding this comment.
any reason why this can't be make.left.right.top.bottom.equalTo(self.view)?
or even make.edges.equalTo(self.view)
st3fan
force-pushed
the
st3fan/Bug1191767LoginWebViewScrolling
branch
from
7642b76
to
35302d2
Compare
st3fan
added a commit
that referenced
this pull request
Aug 7, 2015
…olling Fixes 1191767 - Do not manually handle keyboard overlapping with WKWebView
isabelrios
pushed a commit
to isabelrios/firefox-ios
that referenced
this pull request
Feb 19, 2024
* Updating existing locales: br, ca, da, dsb, en, es-AR, eu, gd, he, hi-IN, hsb, it, ka, kk, lo, nl, nn, pl, pt-BR, ro, sq, ta, th, tr, zh-CN * Importing new locales: an, ia, hy-AM * Include all locales in screenshots.sh
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch removes all keyboard handling code and lets the WKWebView handle it.