Bug 1194726 - Blank Tabs #967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Worth a shot. (Fold those commits!) |
Added check for WKErrorCode.WebContentProcessTerminated with logging and reload.
sleroux
force-pushed
the
sleroux/Bug1194726-BlankTabs
branch
from
b7ae193
to
6276c1e
Compare
isabelrios
pushed a commit
to isabelrios/firefox-ios
that referenced
this pull request
Feb 19, 2024
…bile#967) * Add Telemetry events * Add find in page event probes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found out that there is an WKErrorCode for an NSError that comes from WebKit for when a WebContent process gets terminated. I've tried adding a check for it in our didFail delegate calls as well as some logging and reload.