Bug 1197628 - Implement cell reuse properly in ClientPickerViewController #984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ller. Created individual classes for each type of cell Moved the creation logic into init for each class to ensure it's only done once, rather than every time it is loaded.
| } | ||
|
|
||
| override init(style: UITableViewCellStyle, reuseIdentifier: String?) { | ||
| nameLabel = UILabel() |
There was a problem hiding this comment.
Nit: We can probably just do let nameLabel = UILabel() and remove this line
fluffyemily
pushed a commit
that referenced
this pull request
Sep 1, 2015
…lient-picker-cell-reuse Bug 1197628 - Implement cell reuse properly in ClientPickerViewController
fluffyemily
deleted the
fluffyemily/Bug1197628-correct-client-picker-cell-reuse
branch
isabelrios
pushed a commit
to isabelrios/firefox-ios
that referenced
this pull request
Feb 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugzilla.mozilla.org/show_bug.cgi?id=1197628
Created individual classes for each type of cell
Moved the creation logic into init for each class to ensure it's only done once, rather than every time it is loaded.