Bug 1199836 - Don't use file:/// URL for session path #993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -346,7 +346,7 @@ extension TabManager { | |||
|
|
|||
| private func tabsStateArchivePath() -> String { | |||
| let documentsPath = NSSearchPathForDirectoriesInDomains(.DocumentDirectory, .UserDomainMask, true)[0] | |||
| return NSURL(fileURLWithPath: documentsPath).URLByAppendingPathComponent("tabsState.archive").absoluteString | |||
| return NSURL(string: documentsPath)!.URLByAppendingPathComponent("tabsState.archive").absoluteString | |||
There was a problem hiding this comment.
I don't think this is the right fix — I think you want
return NSURL(fileURLWithPath: documentsPath).URLByAppendingPathComponent("tabsState.archive").path
|
@rnewman Both work, but I agree that it makes more sense to pull the path from a file URL than to construct an |
|
LGTM |
thebnich
added a commit
that referenced
this pull request
Aug 31, 2015
Bug 1199836 - Don't use file:/// URL for session path
isabelrios
pushed a commit
to isabelrios/firefox-ios
that referenced
this pull request
Feb 19, 2024
* Fixes mozilla-mobile#988: Fix failing UI tests * Fix SettingApperanceTests (mozilla-mobile#1002) * Fixes mozilla-mobile#999: update Carthage for AutocompleteTextField (mozilla-mobile#1000) * Fixes mozilla-mobile#993: Update Mozilla section to include rate focus (mozilla-mobile#998) * Fix TrackingProtectionSettings Test * Add check for home func * Fix WebsiteAccessTest keyboard focus error * Stopped request for review in test mode * Add support for Klar reviews * Fix testDisableAutocomplete (mozilla-mobile#1004)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Booboo from replacing
stringByAppendingPathComponent. We want a regular absolute path URL, not afile:///URL.