Skip to content
This repository has been archived by the owner on Sep 4, 2023. It is now read-only.

Form translation component should be always on top #16

Closed
michnov opened this issue Dec 15, 2021 · 4 comments
Closed

Form translation component should be always on top #16

michnov opened this issue Dec 15, 2021 · 4 comments
Labels
bug Something isn't working outbound-translation Issues and Requests for outbound translation

Comments

@michnov
Copy link

michnov commented Dec 15, 2021

Even though the Outbound/Form translation component cannot be implemented as a native panel in the chrome (since it is not allowed for extensions to make use of XUL/XPCOM), it should act so and resemble it as much as possible. One of the expected features is that it always stays on top.

The following webpages show that in the implementation that I tested (https://github.com/mozilla/firefox-translations/actions/runs/1458463171), it is not always the case.

https://karriere.deutschebahn.com/karriere-de/jobs/Kontaktformular-4199212
image

https://www.tajmac-zps.cz/kontakte (then click on "Schreiben Sie uns/Write to us")
image

@michnov
Copy link
Author

michnov commented Dec 15, 2021

Please let me know if there is an updated version of the extension that I should use.
My version of Nightly: 97.0a1

@andrenatal
Copy link
Contributor

Another case:

Install current extension
https://www.booking.com/hotel/gb/park-plaza-westminster-bridge.es.html
Click translate
Click Yes to enable translations of forms (and wait an unusually long time for "Loading form translation")
Click "Ask a question." lower down in the page to open a modal dialogue.
Click on the textarea.

@andrenatal andrenatal added bug Something isn't working outbound-translation Issues and Requests for outbound translation labels Jan 26, 2022
@andrenatal
Copy link
Contributor

Closed in favor of #54

@andrenatal
Copy link
Contributor

This was fixed by 2602bad. I couldn't reproduce any of these behaviors with that patch.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working outbound-translation Issues and Requests for outbound translation
Projects
None yet
Development

No branches or pull requests

2 participants