Skip to content
This repository has been archived by the owner on Sep 4, 2023. It is now read-only.

Empty info/notification popup showing #19

Closed
Booligoosh opened this issue Dec 24, 2021 · 3 comments
Closed

Empty info/notification popup showing #19

Booligoosh opened this issue Dec 24, 2021 · 3 comments

Comments

@Booligoosh
Copy link

I have Firefox Translations enabled by setting extensions.translations.disabled on Firefox Nightly 97.0a1 (2021-12-17) (64-bit) running on Pop!_OS.

Clicking the translate icon in the URL bar will bring up an empty info bar like so:
Screenshot from 2021-12-24 21-56-32

Inspecting the browser console, I see the following errors when clicking the translate button:

notif.init is not a function TranslationBrowserChromeUi.js:313
    showTranslationInfoBar moz-extension://93675596-b356-4a58-bf90-e7e021642882/experiment-apis/translateUi/TranslationBrowserChromeUi.js?cachebuster=1640342430870:313
    onClickCallback moz-extension://93675596-b356-4a58-bf90-e7e021642882/experiment-apis/translateUi/TranslationBrowserChromeUi.js?cachebuster=1640342430870:263
    PopupNotifications_fireCallback resource://gre/modules/PopupNotifications.jsm:1693
    notificationsToShow resource://gre/modules/PopupNotifications.jsm:1213
    filter self-hosted:242
    PopupNotifications_showPanel resource://gre/modules/PopupNotifications.jsm:1208
    PopupNotifications_update resource://gre/modules/PopupNotifications.jsm:1422
    PopupNotifications_reshowNotifications resource://gre/modules/PopupNotifications.jsm:1628
    PopupNotifications_onIconBoxCommand resource://gre/modules/PopupNotifications.jsm:1604
    handleEvent resource://gre/modules/PopupNotifications.jsm:802

Followed by:

TypeError: can't access property "split", n.message is null PopupNotifications.jsm:939:17
    _formatDescriptionMessage resource://gre/modules/PopupNotifications.jsm:939
    PopupNotifications_refreshPanel resource://gre/modules/PopupNotifications.jsm:987
    forEach self-hosted:208
    PopupNotifications_refreshPanel resource://gre/modules/PopupNotifications.jsm:967
    PopupNotifications_showPanel resource://gre/modules/PopupNotifications.jsm:1224
    PopupNotifications_update resource://gre/modules/PopupNotifications.jsm:1422
    PopupNotifications_reshowNotifications resource://gre/modules/PopupNotifications.jsm:1628
    PopupNotifications_onIconBoxCommand resource://gre/modules/PopupNotifications.jsm:1604
    handleEvent resource://gre/modules/PopupNotifications.jsm:802

I tried having a look around the code but don't know enough about the workings of internal browser extensions to figure out the issue!

@Booligoosh Booligoosh changed the title Empty notification popup showing Empty info/notification popup showing Dec 24, 2021
@andrenatal
Copy link
Contributor

Hi @Booligoosh , we are planning to replace the in-tree version in a couple of weeks that's going to fix this issue you are seeing. Thanks for reporting! I'll leave this issue open until we land the update.

@Booligoosh
Copy link
Author

Awesome, thanks for all the great work!

@andrenatal
Copy link
Contributor

Sorry but was decided to not pursue browser integration at this moment anymore. So @Booligoosh could you please file this at https://bugzilla.mozilla.org/home so that someone could offload that from gecko-dev?

Thank you!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants