Skip to content
This repository has been archived by the owner on Sep 4, 2023. It is now read-only.

Incorporate end-to-end integration tests #49

Closed
andrenatal opened this issue Jan 24, 2022 · 2 comments · Fixed by #106
Closed

Incorporate end-to-end integration tests #49

andrenatal opened this issue Jan 24, 2022 · 2 comments · Fixed by #106
Assignees
@andrenatal
Labels
bug Something isn't working
Milestone
W2

Comments

@andrenatal
Copy link
Contributor

We need incorporate tests. Since them are not going to be shipped in the xpi, I'd be fine if we merge these https://github.com/mozilla-extensions/firefox-translations/tree/main/test after we confirm they actually work (I recall we had issues before), or we can draw inspirations from https://github.com/andrenatal/gecko-dev/tree/fxt/browser/extensions/translations/test/browser and try to run it here.
@andrenatal
Copy link
Contributor Author

See #47 (comment)

@andrenatal andrenatal mentioned this issue Jan 24, 2022
Merged
@andrenatal andrenatal added the bug Something isn't working label Jan 26, 2022
@andrenatal andrenatal self-assigned this Feb 4, 2022
@andrenatal
Copy link
Contributor Author

andrenatal commented Feb 4, 2022 •
edited
Loading

Let's get inspiration from here: https://github.com/andrenatal/gecko-dev/tree/d515f5b46846d5b582c2a375c54afdbef47e333b/browser/extensions/translations/test/browser

@andrenatal andrenatal changed the title Incorporate unit/integration tests Incorporate end-to-end integration tests Feb 4, 2022
@andrenatal andrenatal modified the milestones: W5, W2 Feb 10, 2022
@andrenatal andrenatal mentioned this issue Feb 16, 2022
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@andrenatal andrenatal

Labels
bug Something isn't working
Projects
None yet
Milestone
W2
Development

Successfully merging a pull request may close this issue.

Introducing end-to-end tests andrenatal/firefox-translations
1 participant
@andrenatal