Remove forced coloring of blog links #3140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmmavis
requested changes
May 13, 2019
|
How did you create that link? I couldn't find a way to add a link using the admin without it being wrapped in a paragraph tag. |
|
@alanmoo guess we should update our fake data generator so it's more realistic 😂 |
|
See #2786 :) |
mmmavis
approved these changes
May 13, 2019
alanmoo
force-pushed
the
gh-3127-blog-link
branch
from
c320ff7
to
bee813a
Compare
Since links are always inside `p` elements, we don’t need to explicitly set the color.
mmmavis
requested changes
May 13, 2019
alanmoo
force-pushed
the
gh-3127-blog-link
branch
from
bee813a
to
2033e53
Compare
mmmavis
requested changes
May 13, 2019
|
Did a quick test. It seems like Wagtail only auto wraps non-block level elements in
|
|
I just destroyed and recreated the review app. https://foundation-mofostaging-pr-3140.herokuapp.com/en/blog/role-suggest-defense/ There's no extra closing paragraph tag in there, just the one I added in the test fixture to replicate the wrapping Wagtail's rich text editor does on save. |
mmmavis
approved these changes
May 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since links are always inside
pelements, we don’t need to explicitly set the color.Closes #3127