Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle crashing_thread = None case #36

Closed
willkg opened this issue Jul 28, 2021 · 2 comments
Closed

handle crashing_thread = None case #36

willkg opened this issue Jul 28, 2021 · 2 comments
Milestone

Comments

@willkg
Copy link
Collaborator

willkg commented Jul 28, 2021

In this code:

https://github.com/mozilla/fx-crash-sig/blob/5f779ef19efb85f9148bf759e92903db313be72c/fx_crash_sig/symbolicate.py#L50-L52

it doesn't handle the case where crashing_thread=None. It should probably do the same thing it does when the crashing_thread >= len(threads).

@willkg willkg added this to the 1.0.0 milestone Nov 22, 2022
@willkg
Copy link
Collaborator Author

willkg commented Nov 24, 2022

I have a crash_ping_sample.json file where the crashing_thread value is a "0".

However, the schema specifies it can only be an integer and has to have a minimum of 0. It can't be a null and can't be a string.

https://github.com/mozilla-services/mozilla-pipeline-schemas/blob/f6e9491adec9d8c225b219222cd657fe7d982997/schemas/telemetry/crash/crash.4.schema.json#L1625-L1627

So... maybe the sample data I've got is bad and I should get some new sample data.

@willkg
Copy link
Collaborator Author

willkg commented Dec 6, 2022

I looked at the data and crashing_thread is in stack_traces.crash_info both of which are nullable, but crashing_thread itself can't be a null. There's some code checking all those things, so I think we're fine there.

Regardless, crashing_thread can't be a string, so the issue here is that something is wrong with the crash ping sample. Closing this out.

@willkg willkg closed this as completed Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant