This repository has been archived by the owner on Apr 3, 2019. It is now read-only.
Updating methods to use buffers, adding tests, addressing feedback #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@warner r? |
| * @param {String} url scrypt helper server url | ||
| * @returns {Object} d.promise Deferred promise | ||
| */ | ||
| function hash(input, salt, url) { | ||
| var p | ||
| var payload = { | ||
| salt: salt, | ||
| salt: salt.toString('utf8'), |
There was a problem hiding this comment.
I think we should treat the salt as an arbitrary binary string. So encode it as hex when we send it to the remote helper, and "encode" it as utf-8 only for the (hopefully temporary) case where we're passing it to a node-scrypt module that doesn't accept a Buffer.
Does the remote scrypt helper expect a regular JSON string as the salt? If so, we should fix that too.
There was a problem hiding this comment.
Yeah to get that fixed we need to update the helper I think
//cc @zaach
|
👍 I'll take a look at getting around sjcl's missing bytes codec. |
zaach
added a commit
that referenced
this pull request
Sep 3, 2013
Updating methods to use buffers, adding tests, addressing feedback
@zaach, please create an issue for this if you haven't already. thanks! |
rfk
pushed a commit
that referenced
this pull request
Oct 24, 2018
The AppError constructor accepts a `stack` property in the options, but previously always assigned `this.stack` to it, leading to Errors with no stack trace. This was confusing our logging infrastructure, which tries to improve the format of the `stack` property. Closes #164
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.