Skip to content
This repository has been archived by the owner on Apr 3, 2019. It is now read-only.

Synthesized device names with OS and form factor look silly #2045

Closed
philbooth opened this issue Aug 10, 2017 · 1 comment
Closed

Synthesized device names with OS and form factor look silly #2045

philbooth opened this issue Aug 10, 2017 · 1 comment
Assignees

Comments

@philbooth
Copy link
Contributor

In #2041, I added the form factor to the synthesized device name to satisfy the outstanding request from #1889. However, having looked at it in detail while working on mozilla/fxa-content-server#5203, I think it looks a bit funny in some cases where we have both the OS and the form factor available:

screen shot 2017-08-10 at 16 47 17

screen shot 2017-08-10 at 16 48 45

Would it be better if we made the name have either OS or form factor, but not both. I mean:

screen shot 2017-08-10 at 16 53 16

screen shot 2017-08-10 at 16 51 06

@ryanfeeley thoughts?

@philbooth
Copy link
Contributor Author

From meeting: second one is better.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant