Skip to content
This repository has been archived by the owner on Apr 3, 2019. It is now read-only.

lockdown passwordStretching parameters #403

Merged
merged 1 commit into from Dec 11, 2013
Merged

Conversation

dannycoates
Copy link
Contributor

Strictly validates the passwordStretching parameters to only allow:

{
  type: 'PBKDF2/scrypt/PBKDF2/v1',
  PBKDF2_rounds_1: 20000,
  scrypt_N: 65536,
  scrypt_r: 8,
  scrypt_p: 1,
  PBKDF2_rounds_2: 20000
}

This should address the immediate concerns of #400 and #401 but the flexibility of these values remains to be defined.

@rfk @warner r?

@rfk
Copy link
Contributor

rfk commented Dec 10, 2013

r+, pending comment from @warner

@ghost ghost assigned warner Dec 11, 2013
@rfk
Copy link
Contributor

rfk commented Dec 11, 2013

explicitly assigning to @warner for a sanity-check before this gets merged

@warner
Copy link
Contributor

warner commented Dec 11, 2013

r+, as long as this is something we can switch out quickly in the future. I expect we'll change the defaults more than once in the coming months, and I wouldn't want to be limited in our choices by a long update cycle on these checks. We might want to remove this server-side restriction altogether by the time we're done.

@dannycoates
Copy link
Contributor Author

We can put these values in config so changes won't involve a code deploy. Merging now, config change in #414

dannycoates added a commit that referenced this pull request Dec 11, 2013
lockdown passwordStretching parameters
@dannycoates dannycoates merged commit 762ec50 into mozilla:master Dec 11, 2013
@dannycoates dannycoates deleted the i401 branch April 30, 2015 19:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants