This repository has been archived by the owner on Apr 3, 2019. It is now read-only.
added app level token expiry #499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rfk .push('r?') |
| }, | ||
| function(err) { | ||
| cb(err); | ||
| cb(err) |
There was a problem hiding this comment.
all right, who left all these semicolons lying around over here?! :-)
|
dannycoates
added a commit
that referenced
this pull request
Jan 16, 2014
added app level token expiry
rfk
pushed a commit
that referenced
this pull request
Oct 24, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements token expiry for
passwordChangepasswordForgotandaccountResettokens.The lifetime (in milliseconds) of each token can be configured in the json config file.
{ "tokenLifetimes": { "accountResetToken": 900000, "passwordChangeToken" 900000, "passwordForgotToken": 900000 } }Deleting expired tokens remains as a TODO and it would still be useful if the data layer could automatically delete tokens proactively, but these are internal issues.