Test refactor #506
Test refactor #506
Conversation
* created test/local for tests that can only be run locally * created test/remote for tests that can run remotely or locally * moved most api level tests to test/remote * much more of the test suite can run remotely now :)
| @@ -20,7 +20,6 @@ notifications: | |||
| skip_join: false | |||
|
|
|||
| env: | |||
| - DB_BACKEND=memory | |||
There was a problem hiding this comment.
lets give travis a break on this one
| this.server.kill('SIGINT') | ||
| this.mail.kill() | ||
| TestServer.prototype.uniqueEmail = function () { | ||
| return crypto.randomBytes(10).toString('hex') + '@restmail.net' | ||
| } |
There was a problem hiding this comment.
this is a really nice addition
In which case, should we configure travis to do the same? |
|
This is really great, /cc @jbonacci to be sure he sees it. r++ |
Maybe. I'm hesitant of allowing "dev only" code or tiny style issues to fail a PR build at this point. I guess we need to discuss what we should consider "errors" vs "warnings" and what should be automated vs manual in a review. |
|
I saw it. :-) Will pass this along to the QA team. |
|
OK. To be thorough, I verified the following: Next I ran this and got a couple of errors (will file a bug), but overall it looks great: Finally I ran this against Prod, with what looks like the very same errors. So cool! |
I divided the tests into 2 types
localandremote. Local tests are either unit tests of internal modules or API tests that need special configuration, for example setting a token lifetime to -1 to test expiry. Remote tests are for testing the API surface and may be run locally or against a remote server. We should try to use remote tests whenever possible.I've moved as many API tests as possible to
test/remoteand the unit tests totest/local. I also started to put the tests in files by endpoint. There's some overlap, but it seems better than before.You can test remotely like this:
We now have 114 tests that run remotely 馃嵃
During development I prefer
npm run test-quickwhich runs without code coverage.Before pushing to github we should run
npm run test-allwhich runs with both db backends an coverage.r? please 馃拫