Skip to content
This repository has been archived by the owner on Apr 3, 2019. It is now read-only.

Mocha tests fail in Opera 12 #1332

Closed
karlht opened this issue Jun 27, 2014 · 10 comments
Closed

Mocha tests fail in Opera 12 #1332

karlht opened this issue Jun 27, 2014 · 10 comments
Assignees
Labels

Comments

@karlht
Copy link

karlht commented Jun 27, 2014

This is the actual cause of #1324, at least for Opera. Turns out that it wasn't that the click wasn't happening, it was that the Javascript before the redirect was failing.

Steps to reproduce:

  1. Download a copy of Opera 12.
  2. Run a content-server and an auth-server locally, using npm start.
  3. Point Opera to: http://127.0.0.1:3030/tests/index.html

Expected:

  1. Tests pass, as they do on Firefox and Chrome.

Actual:

  1. Anywhere between 4 and 8 test failures per run, including an inability to verify certs.

Obviously, testing this on IE using a local install is significantly more hassle.

@karlht
Copy link
Author

karlht commented Jun 27, 2014

Testing on IE 10 and 11 using Sauce also consistently show failing tests; see #1334. Unfortunately, determining which tests are failing on IE through Sauce Labs is ... challenging.

Both Firefox and Chrome pass these same tests consistently (10 out of 10 tries).

@pdehaan pdehaan added the tests label Jun 28, 2014
@pdehaan pdehaan added this to the train-17 (Jul 14) milestone Jun 30, 2014
@shane-tomlinson
Copy link

@karlht - are the same tests failing consistently? Can you paste in which tests are failing for you? More info please!

@shane-tomlinson
Copy link

Link to mozilla/fxa-js-client#121

@karlht
Copy link
Author

karlht commented Jul 2, 2014

@shane-tomlinson I'll get you some annotated console-reporter output later today.

@shane-tomlinson
Copy link

@shane-tomlinson I'll get you some annotated console-reporter output later today.

Thanks @karlht!

@karlht
Copy link
Author

karlht commented Jul 2, 2014

Yes, the same tests are failing consistently.

The worrisome ones are changePassword, isPasswordResetComplete, and certificateSign.
Output pasted below:

changePassword
✖
changes the user's password ‣
Cannot convert 'a' to object
<anonymous function: toBits>([arguments not available])@http://localhost:3030/bower_components/fxa-js-client/fxa-client.js:439
<anonymous function: unbundleKeyFetchResponse>([arguments not available])@http://localhost:3030/bower_components/fxa-js-client/fxa-client.js:1811
<anonymous function: FxAccountClient.prototype.accountKeys>([arguments not available])@http://localhost:3030/bower_components/fxa-js-client/fxa-client.js:2314
onSettled([arguments not available])@http://localhost:3030/bower_components/fxa-js-client/fxa-client.js:1317
flush([arguments not available])@http://localhost:3030/bower_components/fxa-js-client/fxa-client.js:1021
handleTimer([arguments not available])@http://localhost:3030/bower_components/fxa-js-client/fxa-client.js:1085
isPasswordResetComplete
✖
password status incomplete ‣
Cannot convert 'a' to object
<anonymous function: toBits>([arguments not available])@http://localhost:3030/bower_components/fxa-js-client/fxa-client.js:439
<anonymous function: unbundleKeyFetchResponse>([arguments not available])@http://localhost:3030/bower_components/fxa-js-client/fxa-client.js:1811
<anonymous function: FxAccountClient.prototype.accountKeys>([arguments not available])@http://localhost:3030/bower_components/fxa-js-client/fxa-client.js:2314
onSettled([arguments not available])@http://localhost:3030/bower_components/fxa-js-client/fxa-client.js:1317
flush([arguments not available])@http://localhost:3030/bower_components/fxa-js-client/fxa-client.js:1021
handleTimer([arguments not available])@http://localhost:3030/bower_components/fxa-js-client/fxa-client.js:1085

certificateSign
✖
signs certificate ‣
undefined
[object Object]

@karlht
Copy link
Author

karlht commented Jul 2, 2014

Other tests failing:

lib/assertion
validate
✖
generates a valid assertion ‣
timeout of 20000ms exceeded
<anonymous function>([arguments not available])@http://localhost:3030/bower_components/mocha/mocha.js:4254

signs the user out, redirects to signin page ‣
desktop context
✖
does not show sign out link ‣
undefined
[object Object]
...
returns true if both old and new passwords are valid and different ‣
✖
"before each" hook ‣
undefined
[object Object]
...
returns false if password is too short ‣
✖
"before each" hook ‣
undefined
[object Object]
...
oauth
✖
redirects to signup_complete after account is verified ‣
AssertionError: expected undefined to equal 'signup_complete'

@shane-tomlinson
Copy link

Perfect, thanks @karlht! That'll make debugging easier - we are seeing the same errors.

@shane-tomlinson
Copy link

Note, tests pass as expected in Opera 22

@ckarlof ckarlof modified the milestones: 2014 Q3 (Sep 30), train-17 (Jul 14) Jul 7, 2014
@vladikoff
Copy link
Contributor

#1316 (comment)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

5 participants