Skip to content
This repository has been archived by the owner on Apr 3, 2019. It is now read-only.

Include country information in client metrics #2718

Closed
rfk opened this issue Jul 9, 2015 · 8 comments
Closed

Include country information in client metrics #2718

rfk opened this issue Jul 9, 2015 · 8 comments

Comments

@rfk
Copy link
Contributor

rfk commented Jul 9, 2015

ref https://bugzilla.mozilla.org/show_bug.cgi?id=1162192#c28

We may need clarification on the exact requirements here, e.g. do we need to geolocate based on IP, and if so how and where will we do that.

@vladikoff
Copy link
Contributor

Let the server look up the ip during post-metrics then throw out the IP.

@vladikoff vladikoff self-assigned this Jul 13, 2015
@vladikoff
Copy link
Contributor

@rfk I looked into this a bit, to get this data we have at least 2 options:

Option 1: use one of the geo ip node modules that use a db of ip addresses
i.e https://github.com/bluesmoon/node-geoip (this uses the MaxMind geoip database that has to be refreshed / redownloaded - there is a module that does that automatically). The "issue" with this approach is that we need to load the database into memory.

Option 2: Mozilla might have a service that will allow us to make an ip request. This is what Heka logs are using currently. issue with this approach is that we need to make external requests to get this data.

@vladikoff vladikoff removed their assignment Jul 27, 2015
@rfk
Copy link
Contributor Author

rfk commented Jul 29, 2015

The "issue" with this approach is that we need to load the database into memory.

What's the overhead? IIRC we don't have much memory pressure in content-server webheads currently, since they mostly serve static content.

@vladikoff do the growth team want/need this for completeness with the GA work you've been doing, or can we background this task for a while?

@rfk
Copy link
Contributor Author

rfk commented Aug 3, 2015

We appear to have this thing: https://github.com/mozilla/geodude, which we could run locally or talk to an existing hosted instance, depending on request and memory overhead tradeoffs.

@vladikoff
Copy link
Contributor

from quick discussion: this seems to be only useful for security related events.

Otherwise Heka should be able to process the logs to get answers re: CDNs if needed

@rfk
Copy link
Contributor Author

rfk commented Oct 14, 2015

I feel like we can close this out until it comes back as a specific ask, either from an external team for campaign metrics, or via a specific question that we ourselves would like to answer. @vladikoff what do you think?

@vladikoff
Copy link
Contributor

I feel like we can close this out until it comes back as a specific ask, either from an external team for campaign metrics, or via a specific question that we ourselves would like to answer. @vladikoff what do you think?

Agreed!

@shane-tomlinson
Copy link

I feel like we can close this out until it comes back as a specific ask, either from an external team for campaign metrics, or via a specific question that we ourselves would like to answer. @vladikoff what do you think?

I have a question - Are there parts of the world that are far from the FxA servers where load time performance suffers?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants