Server should not tolerate a missing flow begin time #4349

philbooth · 2016-10-31T13:27:40Z

Currently, the content server attempts to fix flow events that are missing a flow begin time. The original motivation for this was concern that the data-flow-begin attribute might get clobbered in the DOM somehow.

But the disaster that is mozilla/fxa-activity-metrics#16 made me realise that we should fail instead. Better that such events don't corrupt the good data.

The text was updated successfully, but these errors were encountered:

philbooth added the waffle:active label Oct 31, 2016

philbooth added this to the FxA-41:signin funnel metrics milestone Oct 31, 2016

philbooth self-assigned this Oct 31, 2016

This was referenced Oct 31, 2016

"Value out of range for 4 bytes" error reported during flow event import mozilla/fxa-activity-metrics#16

Closed

fix(metrics): ignore flow events if begin time is missing #4351

Merged

philbooth added waffle:review and removed waffle:active labels Oct 31, 2016

vladikoff closed this as completed in #4351 Oct 31, 2016

vladikoff removed the waffle:review label Oct 31, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Server should not tolerate a missing flow begin time #4349

Server should not tolerate a missing flow begin time #4349

philbooth commented Oct 31, 2016 •

edited

Loading

Server should not tolerate a missing flow begin time #4349

Server should not tolerate a missing flow begin time #4349

Comments

philbooth commented Oct 31, 2016 • edited Loading

philbooth commented Oct 31, 2016 •

edited

Loading