chore(sms): Store allowed phone numbers in a Set

mozilla · Nov 15, 2017 · 17a9459 · 17a9459
1 parent 7822603
commit 17a9459
Showing 1 changed file with 3 additions and 7 deletions.
diff --git a/lib/settings/allowed_phone_numbers.js b/lib/settings/allowed_phone_numbers.js
@@ -13,15 +13,11 @@ module.exports = (config, Settings, log) => {
     }
 
     isAllowed(phoneNumber) {
-      return phoneNumber in this.phoneNumbers
+      return this.phoneNumbers.has(phoneNumber)
     }
 
     setAll(phoneNumbers) {
-      this.phoneNumbers = {}
-      phoneNumbers.forEach((phoneNumber) => {
-        this.phoneNumbers[phoneNumber] = true
-      })
-      return Object.keys(this.phoneNumbers)
+      this.phoneNumbers = new Set(phoneNumbers)
     }
 
     validate(phoneNumbers) {
@@ -33,7 +29,7 @@ module.exports = (config, Settings, log) => {
     }
 
     toJSON() {
-      return Object.keys(this.phoneNumbers)
+      return Array.from(this.phoneNumbers)
     }
   }