fix(tests): remove old code coverage tool (#173), r=@vbudhram

Fixes #164

package.json

@@ -34,7 +34,6 @@
     "restify": "4.1.1"
   },
   "devDependencies": {
-    "ass": "git://github.com/jrgm/ass.git#5be99ee7abc9fcf63f9ebcc37b151b9c822146d1",
     "eslint-config-fxa": "2.1.0",
     "grunt": "1.0.1",
     "grunt-bump": "0.8.0",
@@ -49,6 +48,6 @@
     "walk": "2.3.x"
   },
   "engines": {
-    "node": ">=0.10.0"
+    "node": ">=4.5.0"
   }
 }

scripts/tap-coverage.js

@@ -5,34 +5,13 @@
  * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
 
 /* eslint-disable no-console */
-if (!process.env.NO_COVERAGE) {
-  var ass = require('ass').enable( {
-    exclude: [ '/test' ]
-  })
-}
-
 var path = require('path'),
-  spawn = require('child_process').spawn,
-  fs = require('fs')
+  spawn = require('child_process').spawn
 
-var p = spawn(path.join(path.dirname(__dirname), 'node_modules', '.bin', 'tap'),
-              process.argv.slice(2), { stdio: 'inherit' })
+var COVERAGE_ARGS = ['--coverage', '--cov']
+if (process.env.NO_COVERAGE) {
+  COVERAGE_ARGS = []
+}
 
-p.on('close', function(code) {
-  if (!process.env.NO_COVERAGE) {
-    ass.report('json', function(err, r) {
-      console.log('code coverage:', r.percent + '%')
-      process.stdout.write('generating coverage.html: ')
-      var start = new Date()
-      ass.report('html', function(err, html) {
-        fs.writeFileSync(path.join(path.dirname(__dirname), 'coverage.html'),
-                         html)
-        process.stdout.write('complete in ' +
-                             ((new Date() - start) / 1000.0).toFixed(1) + 's\n')
-        process.exit(code)
-      })
-    })
-  } else {
-    process.exit(code)
-  }
-})
+spawn(path.join(path.dirname(__dirname), 'node_modules', '.bin', 'tap'),
+  process.argv.slice(2).concat(COVERAGE_ARGS), { stdio: 'inherit', env: process.env })

test/customs_server_stub.js

@@ -2,5 +2,4 @@
  * License, v. 2.0. If a copy of the MPL was not distributed with this
  * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
 
-require('ass')
 require('../bin/customs_server')

test/local/ban_tests.js

@@ -1,7 +1,6 @@
 /* Any copyright is dedicated to the Public Domain.
  * http://creativecommons.org/publicdomain/zero/1.0/ */
 
-require('ass')
 var test = require('tap').test
 var log = {
   info: function () {},

test/local/email_record_tests.js

@@ -1,7 +1,6 @@
 /* Any copyright is dedicated to the Public Domain.
  * http://creativecommons.org/publicdomain/zero/1.0/ */
 
-require('ass')
 var test = require('tap').test
 var emailRecord = require('../../lib/email_record')
 

test/local/ip_blocklist_tests.js

@@ -1,7 +1,6 @@
 /* Any copyright is dedicated to the Public Domain.
  * http://creativecommons.org/publicdomain/zero/1.0/ */
 
-require('ass')
 var fs = require('fs')
 var Promise = require('bluebird')
 var test = require('tap').test

test/local/ip_email_record_tests.js

@@ -1,7 +1,6 @@
 /* Any copyright is dedicated to the Public Domain.
  * http://creativecommons.org/publicdomain/zero/1.0/ */
 
-require('ass')
 var test = require('tap').test
 var ipEmailRecord = require('../../lib/ip_email_record')
 

test/local/ip_record_tests.js

@@ -1,7 +1,6 @@
 /* Any copyright is dedicated to the Public Domain.
  * http://creativecommons.org/publicdomain/zero/1.0/ */
 
-require('ass')
 var test = require('tap').test
 var ipRecord = require('../../lib/ip_record')
 

test/local/sms_record_tests.js

@@ -1,7 +1,6 @@
 /* Any copyright is dedicated to the Public Domain.
  * http://creativecommons.org/publicdomain/zero/1.0/ */
 
-require('ass')
 var test = require('tap').test
 var smsRecord = require('../../lib/sms_record')