This repository has been archived by the owner on Apr 3, 2019. It is now read-only.
fix(deps): add filtered npm audit support #280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shane-tomlinson
added
train-124
waffle:blocked
and removed
train-123
waffle:active
labels
g-k
force-pushed
the
filtered-npm-audit
branch
from
f1a25a1
to
fbc7d3b
Compare
| @@ -36,6 +37,7 @@ | |||
| "restify-safe-json-formatter": "0.3.0" | |||
| }, | |||
| "devDependencies": { | |||
| "audit-filter": "^0.3.0", | |||
There was a problem hiding this comment.
Can you remove the "^" prefix here?
shane-tomlinson
approved these changes
Oct 30, 2018
There was a problem hiding this comment.
r+, I'll open a separate PR to remove the "^", thanks @g-k!
ghost
removed
|
Thanks! I thought I removed the "^", but maybe that was a different PR. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs: #270, #271
mozilla/fxa#303
https://bugzilla.mozilla.org/show_bug.cgi?id=1478025
edit: this could be a grunt task too though it's been awhile since I've written grunt tasks.