-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Navigating to about:addons causes Marionette to hang #715
Comments
We recently made a number of changes to the page loading algorithm in Firefox. Could you try this again with the latest Firefox Nightly to see if that makes a difference? cc @whimboo |
|
Do you have a trace-level log from that run? |
geckodriver log with nightly:
|
Nothing in this trace log shows that a |
I just go to the addons page manually. if it helps this is the log that includes going to about:addons through geckodriver:
|
Well, if the page doesn't load when you are not using geckodriver, then something is wrong in Firefox or something is blocking the network connection. It sounds like a good candidate to get an answer from support.mozilla.org. Basically the remote page which should load there is controlled via the preference |
Like I said in the description, this issue happens only when I start firefox with geckodriver v0.16. You asked why there wasn't a get request to If I start Firefox with geckodriver v0.15, this issue does not happen. For the value of It still looks to me that some changes between 0.15 and 0.16 in geckodriver have triggered this issue, because there is no other way I can reproduce it yet. Can we re-open this issue? The culprit might be in firefox or a dependence of geckodriver, but until we know for sure I think we should keep this issue open. |
Oh, now I see. So yes, there was indeed a change, which modified this preference and may should not have done it for this preference at the first place. @andreastt knows more about it. |
From the trace log above, it’s not apparent that about:addons fails to load:
The @KSKS If I understand you correctly, if you set this preference to something else, e.g. |
@andreastt I didn't try to set the preference to something else before, but I just tried it based on your comment and the problem doesn't go away.
It returns 404 even on a Firefox that was started by geckodriver v0.15, but its |
The pref was still set to In any case, it’s obviously not great for us to pick up a remote resource. Changing |
@KSKS can you please check which value |
The value is |
I had a look at the latest attached trace log and I miss certain parts from it. Is this really a trace log? I asked because I cannot find any |
I just run it again and it has similar log (below). The log I posted has entries that said
|
Using the Python bindings for Selenium with GeckoDriver the following entries should appear when
I don't see those in your trace log. There is nothing else you would have to specify given that geckodriver forwards it to Firefox. Can you tell us which binding you are using and which version of it? |
I am using Javascript (webdriver.js) selenium 3.4.0. The interesting thing is, I just used the same test script that I used to generate those logs on Windows to run on Mac, and the log is showing entires with |
I narrow down when the issue occur in the commit history. With the commit 74fb9c7, the issue didn't happen, but on 6d25d38, the issue started showing up. Looking at the changes between these two commits, I am guessing it happened on 6f1e3c1, where the bulk of changes happened. but I can't verify for sure because that commit can't compile. I am testing these with Firefox 53, because nightly can't connect with geckodrivers built from these older commits. |
I just try it with geckodriver.exe running as a standalone process, connected with webdriver.js via localhost:4444, and I still don't see any log entries with |
Interesting. Can you please file a separate issue for this? Beside that do you see the same behavior on MacOS? If yes, can you please provide the trace log from that platform instead? |
Can you please set |
But the macOS log contains log entries from Log.jsm:
|
Setting the value of |
i also have the problem python 2.7 from selenium import webdriver
driver = webdriver.Firefox() geckodriver
|
@wengoooooooo I can’t see that that’s the same issue? You aren’t navigating to about:addons at all. |
@andreastt it's the same issue. driver = webdriver.Firefox()
driver.get("about:addons") geckodriver.log 1494950842046 geckodriver INFO Listening on 127.0.0.1:3363
1494950756287 geckodriver::marionette INFO Starting browser \\?\C:\Program Files (x86)\Mozilla Firefox\firefox.exe with args ["-marionette"]
1494950756752 addons.manager DEBUG Application has been upgraded
1494950756752 addons.manager ERROR startup failed: [Exception... "Component returned failure code: 0x80070057 (NS_ERROR_ILLEGAL_VALUE) [nsIFile.create]" nsresult: "0x80070057 (NS_ERROR_ILLEGAL_VALUE)" location: "JS frame :: resource://gre/modules/FileUtils.jsm :: FileUtils_getDir :: line 70" data: no] Stack trace: FileUtils_getDir()@resource://gre/modules/FileUtils.jsm:70 < FileUtils_getFile()@resource://gre/modules/FileUtils.jsm:42 < validateBlocklist()@resource://gre/modules/AddonManager.jsm:671 < startup()@resource://gre/modules/AddonManager.jsm:834 < startup()@resource://gre/modules/AddonManager.jsm:3129 < observe()@resource://gre/components/addonManager.js:65
1494950756754 addons.manager DEBUG Completed startup sequence
JavaScript error: resource://gre/modules/AddonManager.jsm, line 1657: NS_ERROR_NOT_INITIALIZED: AddonManager is not initialized
*** Blocklist::_preloadBlocklistFile: blocklist is disabled
1494950758596 Marionette INFO Listening on port 3262
JavaScript error: resource://gre/modules/AddonManager.jsm, line 2570: NS_ERROR_NOT_INITIALIZED: AddonManager is not initialized
1494950759090 Marionette WARN TLS certificate errors will be ignored for this session
JavaScript error: resource://gre/modules/AddonManager.jsm, line 2010: NS_ERROR_NOT_INITIALIZED: AddonManager is not initialized
JavaScript error: resource://gre/modules/FileUtils.jsm, line 70: NS_ERROR_ILLEGAL_VALUE: Component returned failure code: 0x80070057 (NS_ERROR_ILLEGAL_VALUE) [nsIFile.create]
1494950818309 addons.productaddons INFO sending request to: https://aus5.mozilla.org/update/3/GMP/53.0.2/20170504105526/WINNT_x86-msvc-x64/zh-CN/release/Windows_NT%206.1.1.0%20(x64)/default/default/update.xml
1494950825209 addons.productaddons INFO Completed downloading document
1494950826635 addons.productaddons INFO downloadXHR File download. status=200
1494950826638 addons.productaddons INFO Downloaded file will be saved to C:\Users\lenovo\AppData\Local\Temp\tmpaddon
1494950832037 addons.productaddons INFO downloadXHR File download. status=200
1494950832040 addons.productaddons INFO Downloaded file will be saved to C:\Users\lenovo\AppData\Local\Temp\tmpaddon
JavaScript error: resource://app/modules/WindowsJumpLists.jsm, line 403: NS_ERROR_FILE_NOT_FOUND: Component returned failure code: 0x80520012 (NS_ERROR_FILE_NOT_FOUND) [nsIJumpListShortcut.app]
JavaScript error: resource://app/modules/WindowsJumpLists.jsm, line 403: NS_ERROR_FILE_NOT_FOUND: Component returned failure code: 0x80520012 (NS_ERROR_FILE_NOT_FOUND) [nsIJumpListShortcut.app] |
@wengoooooooo The Loading has nothing to do with Marionette in your last comment, it would appear it is struggling to speak to https://addons.mozilla.org. Your log doesn't show a navigation either to that site. |
So I was able to get this reproduced. It's all because the add-on manager and other components cannot be correctly initialized. Reason is the strange path as used for starting Firefox. I will work on a fix via https://bugzilla.mozilla.org/show_bug.cgi?id=1368965. |
This doesn't seem to be related to window handles. I assume you mean https://bugzilla.mozilla.org/show_bug.cgi?id=1364385? |
Sorry, yes I do. Thanks for noticing that. |
I fall on this bug with the message "NS_ERROR_NOT_INITIALIZED: AddonManager is not initialized" while running webdriver 3.4.0 with firefox on windows 7. As a workaround, what I did is go back to an older version of geckodriver. With version 0.15.0, it works well until a correction of bug is done either in geckodriver or in firefox... |
The fix for geckodriver landed via the before mentioned bug, and will be part of the next release of geckodriver maybe even this week. The initially reported issue with failing to load |
This issue has been automatically locked since there has not been any recent activity after it was closed. If you have run into an issue you think is related, please open a new issue. |
Firefox Version
53
Platform
Windows
geckodriver v0.16.1
selenium-webdriver 3.4.0
Steps to reproduce -
Start Firefox with webdriver.js
Goes to Tools -> Add-ons in Firefox
The page never finish "loading", can't add/manage add-ons manually or programmatically
geokodriver log:
This doesn't reproduce on OSX.
This doesn't reproduce with geokodriver v0.15.0
I also tried to set the Firefox profile to an existing profile that didn't have this issue, but it still occurs.
The text was updated successfully, but these errors were encountered: