Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Persist search state in BigQuery table view #106

Closed
wlach opened this issue Oct 13, 2020 · 3 comments
Closed

Persist search state in BigQuery table view #106

wlach opened this issue Oct 13, 2020 · 3 comments
Assignees

Comments

@wlach
Copy link
Contributor

wlach commented Oct 13, 2020

In the BigQuery table view we currently allow the user to search through the column names to find the ones of interest:

image
http://localhost:5000/#!/apps/mozphab/tables/usage

It would be very handy if we could persist that search in the URL (and restore it when they visit it), so that people could link to specific views and have the search prepopulated. In the above example, that would be:

http://localhost:5000/#!/apps/mozphab/tables/usage?search=build

To perform this task, have a look at the documentation for page.js, which is what we currently use for routing: https://visionmedia.github.io/page.js/

You will probably need to modify the main router (App.svelte) in addition to the component for the table view.

@wlach wlach assigned Riju19 and unassigned oalbacha Oct 22, 2020
@wlach
Copy link
Contributor Author

wlach commented Oct 22, 2020

After talking to @oalbacha, I'm going to reassign to @Riju19

@Riju19
Copy link
Contributor

Riju19 commented Nov 4, 2020

Pull Request #170 fixes this issue. Can we close this one?

@wlach
Copy link
Contributor Author

wlach commented Nov 4, 2020

Pull Request #170 fixes this issue. Can we close this one?

Yup! Usually it closes automatically, will do so now.

@wlach wlach closed this as completed Nov 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants