Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Python linting to CI and make it easy to run #54

Closed
wlach opened this issue Oct 1, 2020 · 2 comments
Closed

Add Python linting to CI and make it easy to run #54

wlach opened this issue Oct 1, 2020 · 2 comments
Assignees

Comments

@wlach
Copy link
Contributor

wlach commented Oct 1, 2020

This issue is intended as an initial onboarding task for potential outreachy applicants. Please do not work on it unless you have completed the initial qualification task and it has been assigned to you.

We only have a minimal amount of python code so far, but we will accumulate more over time. To keep the quality level up, we should enable linting with flake8, black, and isort.

This is a somewhat non-trivial issue, as it will involve:

  • Setting up circleci to run python code (it only validates javascript at the moment)
  • Writing up the correct linter configuration (always harder than it seems)

Some prior art which might be helpful is the mozregression repository where I recently added some linter code:

mozilla/mozregression#575

Note however that it uses travis rather than circleci. You'll need to do some extra research to get this going with CircleCI.

@wlach wlach added the outreachy label Oct 2, 2020
@wlach
Copy link
Contributor Author

wlach commented Oct 12, 2020

@Riju19 will work on this (can assign when they accept the github invitation)

@Riju19
Copy link
Contributor

Riju19 commented Oct 12, 2020

Thanks @wlach, I'll start working on this right away

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants