Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect path for services folder in init script #5

Closed
rawnsley opened this issue Oct 10, 2022 · 2 comments
Closed

Incorrect path for services folder in init script #5

rawnsley opened this issue Oct 10, 2022 · 2 comments

Comments

@rawnsley
Copy link
Contributor

This variable:

servicesdir=$(readlink -f $basedir/../services)

resolves as blank on my installation (on MacOS), which means that the clone path in this line:

git clone https://github.com/mozilla/reticulum.git $servicesdir/reticulum

is /reticulum, which can't resolve because it is root.

I'm guessing that there is some sort of convention to map a services folder in the parent folder?
@bryanenders bryanenders mentioned this issue Oct 18, 2022
Merged
@bryanenders
Copy link
Contributor

Good catch, @rawnsley! The fix should be merged shortly.

@bryanenders
Copy link
Contributor

Fixed in #9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rawnsley @bryanenders