Extract container initialization to bin/init #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryanenders
force-pushed
the
extract-init
branch
from
71de43d
to
f561c26
Compare
Why --- Memory issues can occur when services retrieve dependencies in parallel. Checking dependencies on every start needlessly slows the operation. The NPM lock files are updated on start, which is undesirable. What ---- * Make dependency retrieval serial * Extract dependency retrieval to `bin/init` * Keep `bin/init` idempotent * Replace `bin/clean` with `bin/reset` * Remove unneeded `depends_on` definitions * Give Hubs Client enough time to build before reporting unhealthy * Allow scripts to be triggered from other directories * Allow `bin/observe` to be launched in an existing tmux session
bryanenders
force-pushed
the
extract-init
branch
from
3e576ee
to
83781fc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Memory issues can occur when services retrieve dependencies in parallel. Checking dependencies on every start needlessly slows the operation. The NPM lock files are updated on start, which is undesirable.
What
bin/initbin/initidempotentbin/cleanwithbin/resetdepends_ondefinitionsbin/observeto be launched in an existing tmux session