Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hover effect over 360 videos is not ideal #2004

Open
gfodor opened this issue Jan 3, 2020 · 9 comments
Open

Hover effect over 360 videos is not ideal #2004

gfodor opened this issue Jan 3, 2020 · 9 comments
Assignees
Labels

Comments

@gfodor
Copy link
Contributor

gfodor commented Jan 3, 2020

Description
When you have a 360 video in the room, if your cursor is over it, it dims for the overlay controls. Most likely we should avoid the hover overlay on 360 videos (since it's impractical to change their volume anyway, which is the main reason you'd have overlays on them)

@gfodor gfodor added bug needs triage For bugs that have not yet been assigned a fix priority labels Jan 3, 2020
@johnshaughnessy johnshaughnessy added good first issue P2 Address when able and removed needs triage For bugs that have not yet been assigned a fix priority labels Jan 6, 2020
@Shivansh2407
Copy link

Can I work on this issue?
Please can you guide me what actually needs to be done sir?

@gfodor
Copy link
Contributor Author

gfodor commented Jan 7, 2020

Thanks for offering to help with this issue! I believe what we want to do here is adjust the behavior in hubs so that 360 video media objects do not display controls on hover.

@gfodor
Copy link
Contributor Author

gfodor commented Jan 7, 2020

I believe there are projection-related properties on the media-video component that can drive that distinction, but I'm not 100% positive.

@Shivansh2407
Copy link

Sure Sir , I will look into it . Can you please tell which file I need to look for?

@gfodor
Copy link
Contributor Author

gfodor commented Jan 8, 2020

Most of this stuff happens in media-views and media-loader, but don't know the exact place offhand where we apply the hover effect.

@SparshKat
Copy link
Contributor

@gfodor if this is still open, should i look into it and work?

@paras151
Copy link

Hi, I wanted to look into this bug. I am very new to this project and have explored a few things, can anyone please guide me on how to reproduce this bug.
Thanks.

@matthewbcool
Copy link
Contributor

You can use this scene (remix to have your own version) to view the hover dim behavior: https://hubs.mozilla.com/scenes/kTkUk96

https://gyazo.com/8862bbae934f40cd8120f344f8461819

@paras151
Copy link

Thanks @matthewbcool. I would like to work on this issue. Can I take this up?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants