Apply stashed first sync on videos before playback and ownership #1556
Conversation
| @@ -361,6 +361,7 @@ AFRAME.registerComponent("media-video", { | |||
|
|
|||
| NAF.utils.getNetworkedEntity(this.el).then(networkedEl => { | |||
| this.networkedEl = networkedEl; | |||
| this.networkedEl.components.networked.applyPersistentFirstSync(); | |||
There was a problem hiding this comment.
as noted in the other PR, any reason we can't push this policy into NAF itself?
There was a problem hiding this comment.
We can't apply the stashed sync in init on networked, the rest of the entity's components are not initialized at that point. If we did apply it then, it would result in those components being created and then overwritten by the rest of Hub's scene and media initialization process.
There was a problem hiding this comment.
In particular, we have to apply the first sync after component inits, but before we do this very next bit, where we try to take ownership of scene-owned media.
There was a problem hiding this comment.
ah interesting. i guess i can't come up with a better idea. renaming the function to be less implementation-centric would be nice, since it's a public API, but i can't think of a much better name. eg notifyPeristentEntityReady or something
There was a problem hiding this comment.
Hmm, actually I think I would like to keep the name explicit since I want it to be clear to us when reading this code.
Fixes #1543 by having networked-aframe stash first-syncs for persistent entities, instead of creating said entities. We then apply the stashed first-sync before deciding on playback state and ownership.
Goes with: