Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Three.js to r147 #5852

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

Bump Three.js to r147 #5852

wants to merge 4 commits into from

Conversation

takahirox
Copy link
Contributor

@takahirox takahirox commented Dec 8, 2022

Major benefits

  • For glTF GPU instancing support
  • For better glTF LOD support
    • More precisely, this upgrade includes some changes needed for upcoming better glTF LOD support.

glTF GPU instancing

Breaking changes

  • Drop glTF KHR_materials_pbrSpecularGlossiness extension support

https://github.com/mrdoob/three.js/wiki/Migration-Guide

Changes in the Hubs Client code base

  • Rename uniform.luminance to uniform.luminanceSky in skybox.js to avoid uniform luminance redefinition in the shader
  • Rename *BufferGeometry to *Geometry to match the latest Three.js API
  • Rename Scene.autoUpdate to Scene.matrixWorldAutoUpdate to match the latest Three.js API

Dependencies

TODO

@takahirox takahirox marked this pull request as ready for review December 10, 2022 05:50
@takahirox takahirox mentioned this pull request Dec 13, 2022
@takahirox takahirox marked this pull request as draft May 26, 2023 20:58
@takahirox
Copy link
Contributor Author

Switched to draft. Currently the latest Three.js release is r152. It doesn't really make sense to upgrade to older revision (r147). When we upgrade Three.js next time, we can upgrade to the latest one. We might reuse this PR or branch because the changes in this PR will be needed anyways.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant