Skip to content
This repository has been archived by the owner on Aug 20, 2018. It is now read-only.

Investigate storing a parsed structure instead of the raw data for classes in JARStore #1186

Closed
marco-c opened this issue Feb 28, 2015 · 5 comments

Comments

@marco-c
Copy link
Contributor

marco-c commented Feb 28, 2015

Right now, we're storing raw class data in JARStore. We could instead store already parsed ClassInfo objects.

@mbebenita
Copy link
Contributor

We should not "parse" class files into JS data structures in the first place. We should just interpret the class file data structure as is. I'm actively working on a PR to do this, and I can use some help. I think time would be better spent on that instead of this bug.

@marco-c
Copy link
Contributor Author

marco-c commented Feb 28, 2015

Yeah, whether we do this or not (and how) definitely depends on the results of #1063.

@mbebenita
Copy link
Contributor

I put up a WIP PR #1188 that tries to do this.

@mykmelez
Copy link
Contributor

We should not "parse" class files into JS data structures in the first place. We should just interpret the class file data structure as is. I'm actively working on a PR to do this, and I can use some help.

#1063 is important; how can we help?

@marco-c
Copy link
Contributor Author

marco-c commented Mar 13, 2015

We're directly using the class file format now.

@marco-c marco-c closed this as completed Mar 13, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants