This repository has been archived by the owner on Aug 20, 2018. It is now read-only.
Fix isFinal for method infos. #1170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Removes 78 uneeded unwinds. |
| @@ -90,7 +90,7 @@ module J2ME { | |||
| return true; | |||
| } | |||
| // XXX Determine whether we can start using the code in this function. | |||
| return false; | |||
| return methodInfo.isFinal; | |||
| var result = methodInfo.isFinal; | |||
There was a problem hiding this comment.
Could we now use the code in this function? Maybe it wasn't working before a1fd332 and it's working now?
There was a problem hiding this comment.
Not yet, that code is only valid if every class in every jar is loaded. However, mbx and I have been chatting on enabling better analysis.
There was a problem hiding this comment.
Ok, could you, just for clarity, comment it out?
brendandahl
force-pushed
the
fix-is-final
branch
from
db3d91a
to
fec2fc6
Compare
|
Looks good to me, just needs to be updated. |
| } | ||
| return result; | ||
| return methodInfo.isFinal; | ||
| // XXX The following can only be used if every class in all jars is loaded. |
There was a problem hiding this comment.
Nit: An enclosing /* */ would have worked too 😄
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.