Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check security token in process_subscribe #83

Closed
vincentfretin opened this issue Apr 20, 2021 · 2 comments · May be fixed by networked-aframe/janus-plugin-sfu#6
Closed

Check security token in process_subscribe #83

vincentfretin opened this issue Apr 20, 2021 · 2 comments · May be fixed by networked-aframe/janus-plugin-sfu#6

Comments

@vincentfretin
Copy link
Contributor

vincentfretin commented Apr 20, 2021

This is one of the point listed in #76 and discussed in #81 (comment)

We need to check if the user is allowed to subscribe to a publisher UserId in process_subscribe similar to what we do in process_join by checking publisher.joined.room_id (later room_ids plural, see #55) is in the JWT room_ids.
Even if the user have no publisher and have not joined any room, the user could subscribe to a publisher who has joined some room, as long as the user have a JWT with that room in the publisher room_ids.

We need to change the signature
Subscribe { what: Subscription }
to
Subscribe { what: Subscription, token: String }

The publisher UserID we want to subscribe to is in the param what { media: UserID }

@vincentfretin
Copy link
Contributor Author

I should be able to work on that Q1 2022, hopefully.

@vincentfretin
Copy link
Contributor Author

This is implemented in this PR in the community fork networked-aframe#6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant