Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add error handling in jsonschema #34

Closed
acmiyaguchi opened this issue Mar 13, 2019 · 0 comments
Closed

Add error handling in jsonschema #34

acmiyaguchi opened this issue Mar 13, 2019 · 0 comments

Comments

@acmiyaguchi
Copy link
Contributor

https://github.com/acmiyaguchi/jsonschema-transpiler/blob/d39b9e7cede239cbe1e83043d451a00de861e4d3/src/jsonschema.rs#L113

The transformation from jsonschema into the ast should provide better error handling for schemas that are not valid. There are a few places where the code will panic instead of propagating useful information up. A Result<T, E> type is appropriate since error messages can help users figure out why their schemas are bad.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant