Skip to content
This repository has been archived by the owner on Aug 26, 2022. It is now read-only.

Commit

Permalink
fix bug 1065965 - When disabled, saving buttons must have a clear "di…
Browse files Browse the repository at this point in the history
…sabled" look

CKEditor buttons are now enabled/disabled appropriately.
  • Loading branch information
Ruben Vereecken committed Oct 1, 2014
1 parent a9a2cfe commit 501d0bf
Showing 1 changed file with 20 additions and 0 deletions.
20 changes: 20 additions & 0 deletions media/js/wiki-edit.js
Expand Up @@ -848,14 +848,30 @@
var $metaDataFields = $form.find(metaSelector);
var editor = CKEDITOR.instances['id_content'];

function setEditorButtonsEnabled(enabled) {
var saveContinue = editor.getCommand('mdn-buttons-save');
var saveEdit = editor.getCommand('mdn-buttons-save-exit');

var state = CKEDITOR.TRISTATE_OFF;
if (!enabled)
state = CKEDITOR.TRISTATE_DISABLED;

if (saveContinue)
saveContinue.setState(state);
if (saveEdit)
saveEdit.setState(state);
}

function onDirty() {
$('.btn-save-and-edit').attr('disabled', false);
$('.btn-save').attr('disabled', false);
setEditorButtonsEnabled(true);
}
// Called when everything is clean
function onClean() {
$('.btn-save-and-edit').attr('disabled', true);
$('.btn-save').attr('disabled', true);
setEditorButtonsEnabled(false);
}

function resetDirty() {
Expand Down Expand Up @@ -906,6 +922,10 @@
if(interval) clearInterval(interval);
interval = setInterval(checkEditorDirtiness, 1500); // 1 seconds is arbitrary, we can update as desired
});
editor.on('instanceReady', function(e) {
if (e.editor == editor)
setEditorButtonsEnabled(false);
});

$(win).on('beforeunload', function() {
if(interval) clearInterval(interval);
Expand Down

0 comments on commit 501d0bf

Please sign in to comment.