This repository has been archived by the owner on Aug 26, 2022. It is now read-only.
Fix Bug 1137652: Add padding for current page in quick links #3102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I had a heck of a time testing this one, the macro that generates the quick-links has changed since the last database dump and I was getting timeouts once I updated the templates. 1) get everything up and running with the new style sheet compiled and being served (so, a hard refresh). 2) find/create a page with a left sidebar (maybe https://developer-local.allizom.org/en-US/docs/Web/API/AnimationEvent but don't do your hard refresh on this page or you lose the sidebar) 3) copy the HTML for #quick-links as generated on prod on https://developer.mozilla.org/en-US/docs/Web/API/AnimationEvent/pseudoElement 4) using dev tools paste the #quick-links HTML in.
openjck
added a commit
that referenced
this pull request
Mar 12, 2015
…-current-item Fix Bug 1137652: Add padding for current page in quick links
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had a heck of a time testing this one, the macro that generates the quick-links has changed since the last database dump and I was getting timeouts once I updated the macro templates.