Skip to content
This repository has been archived by the owner on Aug 26, 2022. It is now read-only.

bug 1218563: Update install docs for Linux, .env-dist.dev, and the sample DB #4130

Merged
merged 3 commits into from Feb 22, 2017

Conversation

jwhitlock
Copy link
Contributor

@jwhitlock jwhitlock commented Feb 10, 2017

  • Move .env-dist to .env-dist.deis, and update make deis-config to use it
  • Create .env-dist.dev for development, and add notes to the install instructions for Linux developers.
  • Update the install documents to use the sample database, and drop bits of the install instructions that aren't needed when you use it.

(note, @metadave gave a thumbs up when it was just the first two items, may not have reviewed the new install instructions.)

@codecov-io
Copy link

codecov-io commented Feb 10, 2017

Codecov Report

Merging #4130 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4130   +/-   ##
=======================================
  Coverage   86.21%   86.21%           
=======================================
  Files         144      144           
  Lines        8876     8876           
  Branches     1187     1187           
=======================================
  Hits         7652     7652           
  Misses        990      990           
  Partials      234      234

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d7d716d...23b0489. Read the comment docs.

@jwhitlock jwhitlock changed the title bug 1218563: Split .env-dist into Deis and Development bug 1218563: Update install docs for Linux, .env-dist.dev, and the sample DB Feb 18, 2017
@@ -43,6 +47,13 @@ Docker setup

cd kuma

#. Initialize and customize ``.env``. Linux users should to set the ``UID``
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: Linux users should to set the

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed, force pushed

@bookshelfdave
Copy link
Contributor

lgtm 👍

* Add details for installing Docker on Linux
* Switch database instructions to use the sample database
* Update Front-end instructions to go in order (install node.js, then
  gulp, and optionally install globally), move below viewing the
  homepage.
* Drop instructions from adding "kumaediting" flag (in sample DB)
* Drop instructions for setting KUMASCRIPT_TIMEOUT (in sample DB)
* Mark GitHub Auth as optional, and move admin password disabling into
  that section.
@jwhitlock jwhitlock merged commit c356f04 into master Feb 22, 2017
@jwhitlock jwhitlock deleted the env_1218563 branch February 22, 2017 15:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants