New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug 1400331: Rename WebExtensions link in main nav. #4428

Merged
merged 1 commit into from Sep 18, 2017

Conversation

Projects
None yet
3 participants
@wbamberg
Contributor

wbamberg commented Sep 15, 2017

I've tested this in a local Kuma instance and it looks all right.

One thing I wasn't sure about was case: I've used "Browser Extensions" here, to match the name in the standard: https://browserext.github.io/browserext/, but the title of the linked page is actually "Browser extensions". I think probably the title of the page should be changed to match the name of the standard.

@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Sep 15, 2017

Codecov Report

Merging #4428 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4428   +/-   ##
=======================================
  Coverage   94.74%   94.74%           
=======================================
  Files         257      257           
  Lines       22695    22695           
  Branches     1670     1670           
=======================================
  Hits        21502    21502           
  Misses        964      964           
  Partials      229      229

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dcce68f...4162837. Read the comment docs.

codecov-io commented Sep 15, 2017

Codecov Report

Merging #4428 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4428   +/-   ##
=======================================
  Coverage   94.74%   94.74%           
=======================================
  Files         257      257           
  Lines       22695    22695           
  Branches     1670     1670           
=======================================
  Hits        21502    21502           
  Misses        964      964           
  Partials      229      229

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dcce68f...4162837. Read the comment docs.

@stephaniehobson

This comment has been minimized.

Show comment
Hide comment
@stephaniehobson

stephaniehobson Sep 18, 2017

Contributor

👍

And it's a good idea to change the page title to match.

Contributor

stephaniehobson commented Sep 18, 2017

👍

And it's a good idea to change the page title to match.

@stephaniehobson stephaniehobson changed the title from bug 1400331: Rename WebExtensions link in main nav. to Fix bug 1400331: Rename WebExtensions link in main nav. Sep 18, 2017

@stephaniehobson stephaniehobson merged commit ffc761b into mozilla:master Sep 18, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment