Skip to content
This repository has been archived by the owner on Aug 26, 2022. It is now read-only.

Fix bug 1400331: Rename WebExtensions link in main nav. #4428

Merged
merged 1 commit into from Sep 18, 2017

Conversation

wbamberg
Copy link

I've tested this in a local Kuma instance and it looks all right.

One thing I wasn't sure about was case: I've used "Browser Extensions" here, to match the name in the standard: https://browserext.github.io/browserext/, but the title of the linked page is actually "Browser extensions". I think probably the title of the page should be changed to match the name of the standard.

@codecov-io
Copy link

Codecov Report

Merging #4428 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4428   +/-   ##
=======================================
  Coverage   94.74%   94.74%           
=======================================
  Files         257      257           
  Lines       22695    22695           
  Branches     1670     1670           
=======================================
  Hits        21502    21502           
  Misses        964      964           
  Partials      229      229

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dcce68f...4162837. Read the comment docs.

@stephaniehobson
Copy link
Contributor

👍

And it's a good idea to change the page title to match.

@stephaniehobson stephaniehobson changed the title bug 1400331: Rename WebExtensions link in main nav. Fix bug 1400331: Rename WebExtensions link in main nav. Sep 18, 2017
@stephaniehobson stephaniehobson merged commit ffc761b into mdn:master Sep 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants