bug 957802: Add Code of Conduct, Update Contributing doc #4674
Conversation
Add the MDN Code of Conduct, and refresh CONTRIBUTING for current practices: * Our process is much closer to GitHub flow than the old WebDev workflow * We have a lot more to say about code style, expecially around tests * Add more guidance around branch names and commit messages * Add more about the code review and deployment processes * Add expectations for a PR to be touched in 2 business days * Drop requirement for two peers to review database changes
7774b14
to
a33bfb0
Compare
Fix some issues that are easier to see when GitHub is rendering the markdown, like long sentence, adding formatting, and fixing links,
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️ Wow! This is a really nice step forward. I even learned some new things reading it, as well as some things I need to improve! Thanks @jwhitlock!
Just a few typos to fix.
CONTRIBUTING.md
Outdated
=============== | ||
The MDN platform is a mature product, which means there aren't always bugs that | ||
are suitable for new contributors. We keep a list of starting mentored bugs on | ||
the [MDN "Getting Involved" page](get-involved). There are interesting MDN |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo: Replace (get-involved)
with [get-involved]
CONTRIBUTING.md
Outdated
and give feedback, or to tell you when we plan to review it. | ||
|
||
[gh-flow]: https://guides.github.com/introduction/flow/ | ||
[install]: https://kuma.readthedocs.io/en/latest/installation.html. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo: remove trailing period (should be https://kuma.readthedocs.io/en/latest/installation.html
)
CONTRIBUTING.md
Outdated
=============== | ||
The MDN platform is a mature product, which means there aren't always bugs that | ||
are suitable for new contributors. We keep a list of starting mentored bugs on | ||
the [MDN "Getting Involved" page](get-involved). There are interesting |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo: replace (get-involved)
with [get-involved]
CONTRIBUTING.md
Outdated
good code as well as bad, be clear when changes are needed, and offer | ||
suggestions for fixing code. Code authors should ask questions when a | ||
suggestion is unclear, and ask for help if needed. On both sides, the review | ||
should be about the code, not the person, and the [code of conduct](coc) must |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo: replace (coc)
with [coc]
[Foo](bar) links to ./bar, but [Foo][bar] uses the later reference [bar]
Thanks for checking the links! I'm new to that format for Markdown links. |
Add the MDN Code of Conduct, and refresh CONTRIBUTING for current practices: