bug 1443586: Make lang preference cookie persistent #4718
Conversation
There was a problem hiding this comment.
Thanks @MatonAnthony! This looks good except the test (see comment below).
kuma/core/tests/test_views.py
Outdated
| @@ -152,6 +152,15 @@ def test_not_possible_to_set_non_locale_cookie(self): | |||
| # No language cookie should be saved as `foo` is not a supported locale | |||
| assert not language_cookie | |||
|
|
|||
| def test_setting_language_cookie_age(self): | |||
There was a problem hiding this comment.
@MatonAnthony I think you'll first have to rebase your branch on master, as the LanguageCookieTest class no longer exists. Once you rebase on the latest master, you could fold this check:
assert language_cookie['max-age'] == settings.LANGUAGE_COOKIE_AGE
into the existing test test_setting_language_cookie_working.
MatonAnthony
force-pushed
the
persistent-lang-cookie-1443586
branch
from
7d15ae9
to
aeead8c
Compare
Codecov Report
@@ Coverage Diff @@
## master #4718 +/- ##
==========================================
- Coverage 95.94% 95.47% -0.48%
==========================================
Files 270 263 -7
Lines 25352 23872 -1480
Branches 1743 1712 -31
==========================================
- Hits 24325 22791 -1534
- Misses 817 871 +54
Partials 210 210
Continue to review full report at Codecov.
|
Increase the max-age of the language preference cookie to one year instead of only the current session. This avoids to ask if people wants to keep their current locale at each of their visits.
MatonAnthony
force-pushed
the
persistent-lang-cookie-1443586
branch
from
aeead8c
to
e9eca98
Compare
There was a problem hiding this comment.
Just to be thorough, I verified this using my local dev environment, and it worked great. Thanks so much @MatonAnthony!
Increase the max-age of the language preference cookie to one
year instead of only the current session.
This avoids to ask if people wants to keep their current locale
at each of their visits.