This repository has been archived by the owner on Aug 26, 2022. It is now read-only.
Only preload .woff2 font files #4728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schalkneethling
approved these changes
Apr 3, 2018
|
Looks like it worked, thanks @schalkneethling 👍
(my first contribution to MDN 🍻) |
|
\o/ Thanks Alex!
Kind Regards,
Schalk Neethling
Senior Front-End Engineer
Mozilla
…On Fri, Apr 6, 2018 at 5:49 PM, Alex Gibson ***@***.***> wrote:
Looks like it worked, thanks @schalkneethling
<https://github.com/schalkneethling> 👍
[image: screenshot-2018-4-6 web performance dashboard]
<https://user-images.githubusercontent.com/400117/38430830-4cda9150-39ba-11e8-828e-3842ba4c424d.png>
(my first contribution to MDN 🍻)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#4728 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AJ3xcIreiXx3QdgXl84jTv6JcKJigpm7ks5tl45sgaJpZM4TEq0X>
.
|
|
Nice, thanks @alexgibson! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I currently have a few pages of MDN listed on the performance dashboard I'm building for our team. Because I'm spending a fair bit of time looking at this, I was intrigued to see a noticable up-tick in both load times and bytes in, as you can see here:
After a bit of digging in the web page test result, I noticed that both
.woffand.woff2files are being loaded, which seemed like a bug:I think this PR should fix the issue because:
.woff2should no longer need.wofffiles.rel="preload"should also support.woff2.