Skip to content
This repository has been archived by the owner on Aug 26, 2022. It is now read-only.

bug 1544084: revert atomic edits #5366

Merged
merged 1 commit into from Apr 22, 2019
Merged

bug 1544084: revert atomic edits #5366

merged 1 commit into from Apr 22, 2019

Conversation

escattone
Copy link
Contributor

It appears that #5348 has broken editing (see mdn/sprints#1366). I'm not sure why, since I can't reproduce it locally or even on stage, so this PR reverts the change that wrapped the edit view in an atomic transaction, in order to restore functionality for the writers while this is investigated further.

@codecov-io
Copy link

codecov-io commented Apr 22, 2019

Codecov Report

Merging #5366 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5366      +/-   ##
==========================================
- Coverage   95.36%   95.36%   -0.01%     
==========================================
  Files         291      291              
  Lines       25110    25108       -2     
  Branches     1826     1826              
==========================================
- Hits        23947    23945       -2     
  Misses        932      932              
  Partials      231      231
Impacted Files Coverage Δ
kuma/wiki/views/edit.py 70.13% <ø> (-0.41%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba6c0b2...654e108. Read the comment docs.

@escattone escattone merged commit ade82a3 into mdn:master Apr 22, 2019
@escattone escattone deleted the fix-broken-edits-1544084 branch April 22, 2019 22:11
@peterbe
Copy link
Contributor

peterbe commented Apr 23, 2019

It's pretty depressing that the tests didn't break as of this mini-custom-revert. I understand why but it's still depressing. Mocking sucks.

By the way, as of that change, I made it so that send_first_edit_email.delay(new_rev.pk) gets called at the end of the transaction. transaction.on_commit still occurs when your view isn't made atomic but it's just that it gets called no matter what happens. Even if something fails later in the view code.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants