Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lock down looker-hub main from accepting PRs with custom changes (except from dataops-looker) #280

Open
scholtzan opened this issue Oct 20, 2021 · 0 comments

Comments

@scholtzan
Copy link
Contributor

We had a couple of instances were PRs with manual changes got opened against looker-hubs main branch and then got merged causing lookml-generator to error out since the pushed files did not match the generated files. Generally, manual changes should be done in spoke-default or spoke-private projects.

It would be good to prevent custom PRs from getting opened against looker-hubs main branch. This way they can't get accidentally merged.
We still want the dataops-looker user to open PRs against it, and possibly admins (or maybe no one?). It should also still be possible for users to create new branches in the project to allow for testing changes.

@scholtzan scholtzan changed the title Lock down looker-hub main from accepting PRs with custom changes Lock down looker-hub main from accepting PRs with custom changes (except from dataops-looker) Oct 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant