Skip to content
This repository has been archived by the owner on May 26, 2022. It is now read-only.

Remove django_workable. #167

Merged
merged 1 commit into from May 20, 2016
Merged

Conversation

glogiotatidis
Copy link
Contributor

@glogiotatidis glogiotatidis commented May 18, 2016

We never actually used workable and now we're moving to another provider.

So @jgmize, @pmclanahan how do you feel about removing django_workable database tables using a migration from the base app? (commit 1086317) Do you think its worth it or should I just go and manually run those commands?

@glogiotatidis glogiotatidis force-pushed the removeworkable branch 2 times, most recently from c881f83 to fc5e3bc Compare May 18, 2016 08:31
@glogiotatidis glogiotatidis changed the title WIP remove workable. Remove django_workable. May 18, 2016
@glogiotatidis glogiotatidis force-pushed the removeworkable branch 2 times, most recently from 6589883 to 1086317 Compare May 18, 2016 09:25
@jgmize
Copy link
Contributor

jgmize commented May 18, 2016

Do you think its worth it or should I just go and manually run those commands?

Personally, I'd run them manually after the code has been deployed. Given that there are no other migrations, it's not worth adding them just for this case. Also, there's a potential race condition where if the migrate command was run as part of a deploy and dropped the tables, the other deployed containers running the previous version of the code talking to the same DB could potentially throw errors. There is also the fact that there's no automatic rollback option as implemented here, and no real downside if you left the unused tables in the DB for a while and dropped them only after there was no possibility of ever needing to roll back to a version of the code that included references to those tables.

@glogiotatidis
Copy link
Contributor Author

All good points jgmize. I'll remove the migrations and apply them manually. Thanks!

@glogiotatidis glogiotatidis merged commit 2df90c3 into mozmeao:master May 20, 2016
@glogiotatidis glogiotatidis deleted the removeworkable branch July 18, 2016 11:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants