Skip to content
This repository has been archived by the owner on May 26, 2022. It is now read-only.

[fix bug 932866] Hamburger Nav Does Not Work FFOS #96

Merged
merged 1 commit into from Dec 12, 2013

Conversation

alexgibson
Copy link
Member

Sadly, it seems Firefox OS doesn't play very well when applying CSS transforms to position: fixed; elements.

This PR includes:

  • Removed the open/close transition on the mobile nav menu.
  • Improved a11y, hiding the mobile nav from screen readers when it is not visible, as well as adding role=navigation.
  • Focus is now set on the mobile nav once it is opened.
  • Fixed an edge-case bug that allowed the page to scroll when touchmove even fired on the empty section below the open mobile nav menu.

Still awaiting confirmation on this direction in the bug, but this PR should at least be good for testing/feedback.

@Osmose
Copy link
Contributor

Osmose commented Dec 3, 2013

Menu works fine now on my Peak, and codewise I don't see anything wrong. You might want to ask Craig for a more detailed frontend review if you want, but IMO this is an r+.

Will merge once we get feedback on the bug (or merge yourself, or comment on this issue to get me to merge, anything is possible!).

@bensternthal
Copy link
Contributor

Let's merge this one.

alexgibson added a commit that referenced this pull request Dec 12, 2013
[fix bug 932866] Hamburger Nav Does Not Work FFOS
@alexgibson alexgibson merged commit 36fcf67 into mozmeao:master Dec 12, 2013
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants